[PATCH] D66887: [test-suite][WIP] Add GCC C Torture Suite as External Test Suite

Thu Aug 29 07:18:48 PDT 2019

lenary marked 2 inline comments as done.
lenary added a comment.

Yeah, I need to review the list of tests to skip, which is on my list to do. I will probably initially review that list by testing on the x86-backend, and then letting other backends add their own lists of tests to skip (as we already have for the riscv backend).

================
Comment at: External/gcc-c-torture/CMakeLists.txt:38
+  # These will compile only
+  function(gcc_torture_compile_test File)
+    get_filename_component(Name ${File} NAME_WE)
----------------
asb wrote:
> I'm not 100% convinced how useful the compile-only tests are for the test-suite repo. I'd welcome other opinions.
Yeah, my new feeling is that these are too hard to integrate into the test suite, because LNT really really really wants to have an executable to run. I've removed them in my most recent update.

================
Comment at: External/gcc-c-torture/README:8
+
+Last checked at SVN version 275024
----------------
asb wrote:
> It would be useful to suggest an appropriate svn export command I think.
Alrighty

Repository:
  rT test-suite

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66887/new/

https://reviews.llvm.org/D66887