[PATCH] D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries

[Jeeva P. via Phabricator via llvm-commits]

pjeeva01 added a comment.

In D59883#1649656 <https://reviews.llvm.org/D59883#1649656>, @jsji wrote:

> > 1. *_massv functions serve as place holder for math functions during loop vectorization. They are not actual entries in the MASS library. I think lowering them to actual entries in the MASS library deserves  a separate pass rather than polluting the TargetLowering.cpp, which is already big as it is.
>
> Why this has to be in `TargetLowering.cpp`, they can be in `PPCISelLowering.cpp`.
>
> > 
> > 
> > 2. If we were to use setLibcallName, we would need to repeat the list of all supported MASS entries in TargetLowering as well. With the current structure, we are reusing the list in VecFuncs.def. Also, this structure sits well with vectorization of math functions with other libraries too, namely: SVML and Accelerate.
>
> Why we can't reusing the list in `VecFuncs.def` with `setLibcallName`?


Yes, the list in VecFuncs.def could be reused in PPCISelLowering. But, PPCISelLowering.cpp is already big as it is. Adding more functions to handle this lowering will only add to its size and a list of features it already supports. Therefore, my preference is to separate out the MASSV lowering functionality into a separate transformation.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59883/new/

https://reviews.llvm.org/D59883