[PATCH] D66913: [Attributor] Use the whitelist for attributes consistently

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 05:54:55 PDT 2019


jdoerfert marked an inline comment as done.
jdoerfert added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1308-1309
     Function *F = getAssociatedFunction();
+    if (!F)
+      return indicatePessimisticFixpoint();
     const IRPosition &FnPos = IRPosition::function(*F);
----------------
uenoku wrote:
> I'm not sure why this check is here. Why not in `initialize`?
Fair point, I'll move them in to initialize.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66913/new/

https://reviews.llvm.org/D66913





More information about the llvm-commits mailing list