[PATCH] D66098: [CostModel] Model all `extractvalue`s as free.

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 04:36:33 PDT 2019


lebedev.ri added a comment.

In D66098#1650630 <https://reviews.llvm.org/D66098#1650630>, @jmolloy wrote:

> I think I'm happy to stamp. I can't think of why this patch might be wrong, and it's easy to back out if someone finds a counterexample. LGTM.




In D66098#1650646 <https://reviews.llvm.org/D66098#1650646>, @dmgreen wrote:

> I ran some ARM and AArch64 tests, which agreed that this is OK for those architectures (although they are probably already covered by what James said above).


Thank you for the review!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66098/new/

https://reviews.llvm.org/D66098





More information about the llvm-commits mailing list