[PATCH] D66932: [LV] Tail-folding, runtime scev checks

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 03:34:38 PDT 2019


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:2699
+  assert(!BB->getParent()->hasOptSize() &&
          "Cannot SCEV check stride or overflow when folding tail");
 
----------------
Error message should be updated as well.


================
Comment at: llvm/test/Transforms/LoopVectorize/X86/tail-folding-scevcheck.ll:12
+; CHECK:       vector.ph:
+; CHECK:       vector.body:
+entry:
----------------
Better also check instructions, not only labels?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66932/new/

https://reviews.llvm.org/D66932





More information about the llvm-commits mailing list