[PATCH] D66825: [10/10] [LLD] [COFF] Silently drop a manifest with language 0, if there's another manifest with a nonzero language id

Thu Aug 29 02:38:26 PDT 2019

mstorsjo marked an inline comment as done.
mstorsjo added inline comments.

================
Comment at: lld/test/COFF/merge-resource-manifest.test:12
+
+# RUN: lld-link /lldmingw /out:%t.exe /entry:main %t.obj %p/Inputs/manifest-lang1.o %p/Inputs/manifest-lang0.o
+# RUN: llvm-readobj --coff-resources %t.exe | FileCheck %s
----------------
mstorsjo wrote:
> MaskRay wrote:
> > Does yaml2obj lack any features that prevents it from generating `manifest-lang0.o` and other object files?
> Hmm, no, yaml2obj should work fine.
> 
> In principle we could also produce them with llvm-rc and llvm-cvtres, but we currently don't have those as test-depends for lld. (And for patch 09/10 I have object files generated with other tools, to test interoperability with them. But a yaml serialization of it should preserve all the necessary detail.
yaml2obj can't synthesize the .res files though, but if you want to, we could add llvm-rc to the list of test dependencies and create it with that. (We do have a number of existing tests with hardcoded .res and resource object files though.)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66825/new/

https://reviews.llvm.org/D66825