[PATCH] D66825: [10/10] [LLD] [COFF] Silently drop a manifest with language 0, if there's another manifest with a nonzero language id

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 29 01:43:53 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/test/COFF/merge-resource-manifest.test:12
+
+# RUN: lld-link /lldmingw /out:%t.exe /entry:main %t.obj %p/Inputs/manifest-lang1.o %p/Inputs/manifest-lang0.o
+# RUN: llvm-readobj --coff-resources %t.exe | FileCheck %s
----------------
Does yaml2obj lack any features that prevents it from generating `manifest-lang0.o` and other object files?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66825/new/

https://reviews.llvm.org/D66825





More information about the llvm-commits mailing list