[compiler-rt] r370243 - Further relax checks in asan-symbolize-bad-path.cpp

Alexander Richardson via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 11:37:53 PDT 2019


Author: arichardson
Date: Wed Aug 28 11:37:53 2019
New Revision: 370243

URL: http://llvm.org/viewvc/llvm-project?rev=370243&view=rev
Log:
Further relax checks in asan-symbolize-bad-path.cpp

It turns out that the DarwinSymbolizer does not print the "in" part for
invalid files but instead prints
#0 0xabcdabcd (.../asan-symbolize-bad-path.cpp.tmp/bad/path:i386+0x1234)
This tests is only checking that asan_symbolize.py doesn't hang or crash,
so further relax the checks to ensure that the test passes on macOS.

Modified:
    compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp

Modified: compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp?rev=370243&r1=370242&r2=370243&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp (original)
+++ compiler-rt/trunk/test/asan/TestCases/Posix/asan-symbolize-bad-path.cpp Wed Aug 28 11:37:53 2019
@@ -2,13 +2,13 @@
 // path.
 // RUN: echo '#0 0xabcdabcd (%t/bad/path+0x1234)' | %asan_symbolize | FileCheck %s -check-prefix CHECK-BAD-FILE
 // Note: can't check for "0xabcdabcd in ?? ??:0" since DarwinSymbolizer will print the file even if it doesn't exist.
-// CHECK-BAD-FILE: #0 0xabcdabcd in
+// CHECK-BAD-FILE: #0 0xabcdabcd
 // CHECK-BAD-FILE-EMPTY:
 
 // Also test that asan_symbolize doesn't assert on an invalid address with a valid file:
 // RUN: %clangxx_asan -O0 %s -o %t
 // RUN: echo '#0 0xabcdabcd (%t+0xabcdabcd)' | %asan_symbolize | FileCheck %s -check-prefix CHECK-BAD-ADDR
-// CHECK-BAD-ADDR: #0 0xabcdabcd in
+// CHECK-BAD-ADDR: #0 0xabcdabcd
 // CHECK-BAD-ADDR-EMPTY:
 
 int main() {




More information about the llvm-commits mailing list