[PATCH] D66724: [AIX]Emit function descriptor csect in assembly

[Jason Liu via Phabricator via llvm-commits]

jasonliu added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1665
+    StringRef SecName(CurrentFnDescSym->getName());
+    MCSectionXCOFF *FnDescSec = OutStreamer->getContext().getXCOFFSection(
+        SecName, XCOFF::XMC_DS, XCOFF::XTY_SD, XCOFF::C_HIDEXT,
----------------
const ?


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1672
+    CurrentFnSym =
+        OutContext.getOrCreateSymbol("." + CurrentFnDescSym->getName());
+    // Set the containing csect.
----------------
Could reuse SecName here? Maybe rename SecName to be FnDescSymName.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1674
+    // Set the containing csect.
+    const Function &F = MF.getFunction();
+    MCSectionXCOFF *FnEntryPointSec =
----------------
Function &F could get reused by line 1662.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1675
+    const Function &F = MF.getFunction();
+    MCSectionXCOFF *FnEntryPointSec =
+        cast<MCSectionXCOFF>(getObjFileLowering().SectionForGlobal(&F, TM));
----------------
const here as well?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66724/new/

https://reviews.llvm.org/D66724