[PATCH] D66309: Introduce infrastructure for an incremental port of SelectionDAG atomic load/store handling

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 09:39:13 PDT 2019


xbolva00 added inline comments.


================
Comment at: test/CodeGen/X86/atomic-unordered.ll:4
 ; RUN: llc -O3 < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mcpu=skylake | FileCheck --check-prefix=CHECK-O3 %s
+; RUN: llc -O3 < %s -mtriple=x86_64-linux-generic -verify-machineinstrs -mcpu=skylake -x86-experimental-unordered-atomic-isel | FileCheck --check-prefix=CHECK-EX %s
 
----------------
reames wrote:
> craig.topper wrote:
> > Can we add a common prefix to share with the two O3 run lines? Looks like our codegen is the same for the majority of the test cases.
> Not quite following the why behind this request?  Is there some (undocumented) feature of FileCheck which merges the check lines or something?
Possibly something like
-check-prefixes=CHECK,CHECK-O3
-check-prefixes=CHECK,CHECK-EX

(not tested, just saw it many times)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66309/new/

https://reviews.llvm.org/D66309





More information about the llvm-commits mailing list