[PATCH] D66718: [DAGCombiner] (insert_vector_elt (vector_shuffle X, Y), (extract_vector_elt X, N), IdxC) -> (vector_shuffle X, Y)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.

I still find naming choices to be actively misleading.
LG otherwise.



================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:16435
   SDValue InsertVal = N->getOperand(1);
+  SDValue Vec = N->getOperand(0);
+
----------------
> There's no need to rename - tbh we don't know its a shuffle at this stage!
But we will only proceed *if* it will be a shuffle. This is a common pattern everywhere else in the code.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66718/new/

https://reviews.llvm.org/D66718