[PATCH] D59883: Lower generic MASSV entries to PowerPC subtarget-specific entries

Jeeva P. via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 28 08:03:23 PDT 2019


pjeeva01 added a comment.

In D59883#1605289 <https://reviews.llvm.org/D59883#1605289>, @jsji wrote:

> Why we need a new pass to do this simple lowering? 
>  Why can't we do it similar to `InitLibcalls` and change the suffixes for subtarget using `setLibcallName`?


A separate pass for MASS lowering is worthwhile because it allows better separation of concerns. 
In the future, if need be, other PPC sub-target specific lowering decisions may be encapsulated in this pass too.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59883/new/

https://reviews.llvm.org/D59883





More information about the llvm-commits mailing list