[PATCH] D65921: [X86] Add DSB subtarget feature. NFC

[Pei, Gen via Phabricator via llvm-commits]

gpei added a comment.

In D65921#1648722 <https://reviews.llvm.org/D65921#1648722>, @RKSimon wrote:

> In D65921#1648674 <https://reviews.llvm.org/D65921#1648674>, @gpei wrote:
>
> > In D65921#1639186 <https://reviews.llvm.org/D65921#1639186>, @RKSimon wrote:
> >
> > > In D65921#1625064 <https://reviews.llvm.org/D65921#1625064>, @gpei wrote:
> > >
> > > > In D65921#1620693 <https://reviews.llvm.org/D65921#1620693>, @RKSimon wrote:
> > > >
> > > > > Is there anything we can add as tests here?
> > > >
> > > >
> > > > It's hard to add tests for this sub-target feature. Could you please give me an example?
> > >
> > >
> > > How are you intending to use this feature? DSB is an uop-cache so are you intending to connect this to the instruction schedulers some how? Or is it going to affect instruction selection decisions?
> >
> >
> > Sorry for replying your message so late. Yes, this feature is for some proprietary passes.
>
>
> Are these passes likely to pushed for review any time soon? I'd really prefer not to have yet more X86 feature flags added to trunk unless we have a clear purpose for them.


Not sure how long, it's depending on the policy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65921/new/

https://reviews.llvm.org/D65921