[PATCH] D61144: [LoopIdiomRecognize] BCmp loop idiom recognition

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 16:46:30 PDT 2019


lebedev.ri added a comment.

In D61144#1643152 <https://reviews.llvm.org/D61144#1643152>, @courbet wrote:

> LGTM. Maybe let's way a couple days to see if @reames has blocking issues ?


@reames please could you clarify whether you have blocking issues here?

Any other loop folk want to review? :)

FWIW i //personally// don't //expect// this to have any issues, the legality check
is really (too?) strict and the rewriting part is doing the right thing
in all the edge-cases i have stumbled into in test-suite.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61144/new/

https://reviews.llvm.org/D61144





More information about the llvm-commits mailing list