[PATCH] D48674: SelectionDAGBuilder, mach-o: Skip trap after noreturn call (for Mach-O)

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.
Herald added a project: LLVM.

These two MachO specific configurations seem like needlessly MachO specific policy decisions. I think it would make more sense for the project overall if we emitted traps for unreachables not preceded by noreturn calls for all targets. As you've noticed, the vast majority of unreachables are from calls to noreturn functions. The remainder account for the confusing and hard to debug fall through cases. I believe noreturn functions rarely return erroneously, and are usually not problematic for the user.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D48674/new/

https://reviews.llvm.org/D48674