[PATCH] D66141: [FileCheck] Forbid using var defined on same line

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 14:20:28 PDT 2019


arichardson added a comment.

In D66141#1647722 <https://reviews.llvm.org/D66141#1647722>, @thopre wrote:

> In D66141#1641237 <https://reviews.llvm.org/D66141#1641237>, @arichardson wrote:
>
> > LGTM except for one minor issue.
>
>
> Hi Alexander,
>
> Was your intention to approve the patch or did you intentionally leave it to others to approve?
>
> Best regards.


While I've made some changes to FileCheck in the past and I'm happy to review all the changes, I feel like someone more familiar with the code should probably give the final approval.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66141/new/

https://reviews.llvm.org/D66141





More information about the llvm-commits mailing list