[PATCH] D66678: [GlobalISel] Replace hard coded dynamic alloca handling with G_DYN_STACKALLOC

[Amara Emerson via Phabricator via llvm-commits]

aemerson marked 2 inline comments as done.
aemerson added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp:3957
+  if (Align) {
+    auto AlignCst = MIRBuilder.buildConstant(IntPtrTy, -Align);
+    Alloc = MIRBuilder.buildAnd(IntPtrTy, Alloc, AlignCst);
----------------
Petar.Avramovic wrote:
> Or use explicit APInt for -Align here just to be sure we make bitmask of appropriate size/value.
You're right, I'll fix this with APInt and commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66678/new/

https://reviews.llvm.org/D66678