[PATCH] D65609: Add gdb pretty printers for a wide variety of libc++ data structures.

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

In D65609#1615158 <https://reviews.llvm.org/D65609#1615158>, @ldionne wrote:

> In D65609#1615153 <https://reviews.llvm.org/D65609#1615153>, @Eugene.Zelenko wrote:
>
> > In D65609#1615142 <https://reviews.llvm.org/D65609#1615142>, @ldionne wrote:
> >
> > > In D65609#1611310 <https://reviews.llvm.org/D65609#1611310>, @Eugene.Zelenko wrote:
> > >
> > > > Please also add installation, since pretty-printers should be shipped with libc++, same as GCC does with libstdc++ and its pretty-printers.
> > >
> > >
> > > Did these pretty-printers exist for libc++ before this patch? If so, how were they shipped?
> >
> >
> > There is separate project on GitHub <https://github.com/koutheir/libcxx-pretty-printers>. It was mentioned in libcxx/docs/UsingLibcxx.rst.
>
>
> I had missed that, thanks!
>
> In that case, this patch should update the documentation.
>
> > GCC ships libstdc++ pretty-printers in <install directory>/share/gcc-<version>/python/libstdcxx/.
>
> I guess we could start with doing the same for libc++'s pretty-printers.


We could check them in for now and then EricWF can do the moving and updating of documentation around when they're happy?

I'm pretty happy with this as is... any objections?

-eric


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65609/new/

https://reviews.llvm.org/D65609