[PATCH] D66534: [ARM] MVE Masked loads and stores

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 27 04:02:27 PDT 2019


samparker added a comment.

Sorry if I've missed it or misunderstood the tests, but are we testing the cases where we need to generated a vsel?



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:4991
+  // Masked stores
+  def : MVE_vector_maskedstore_typed<v16i8, MVE_VSTRBU8, maskedstore, 0>;
+  def : MVE_vector_maskedstore_typed<v8i16, MVE_VSTRHU16, alignedmaskedstore16, 1>;
----------------
Aren't the aligned patterns the same for both LE and BE? If so, we can refactor this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66534/new/

https://reviews.llvm.org/D66534





More information about the llvm-commits mailing list