[PATCH] D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for the patch.
We wanted to avoid any complex `DIExpression` here, so this looks good. In order to support it here, we need to add fully support within the `AsmPrinter` (`DwarfDebug`, `DwarfExpression`, `DwarfCompileUnit`) and then enable it here.



================
Comment at: llvm/test/DebugInfo/Mips/entry-value-non-empty-expr.ll:50
+
+attributes #0 = { nounwind }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
I think we don't need the attributes.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66746/new/

https://reviews.llvm.org/D66746