[PATCH] D66308: [InstCombine] Fold select with ctlz to cttz
    Hal Finkel via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Aug 26 20:52:36 PDT 2019
    
    
  
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lib/Transforms/InstCombine/InstCombineSelect.cpp:790
+/// \code
+///   int a = clz(x & -x);
+//    x ? 31 - a : a;
----------------
I'd prefer that the comments use the same abbreviations as the intrinsics, ctlz and cttz (instead of clz and ctz).
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66308/new/
https://reviews.llvm.org/D66308
    
    
More information about the llvm-commits
mailing list