[PATCH] D65408: [Attributor] Heap-To-Stack Conversion

Stefan Stipanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 18:20:56 PDT 2019


sstefan1 marked an inline comment as done.
sstefan1 added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:2729
+          if (Ptr == MallocCall) {
+            FreesForMalloc[const_cast<Instruction *>(MallocCall)].insert(&I);
+            return true;
----------------
jdoerfert wrote:
> No need to check, just put it in `FreesForMalloc` (though I'm unclear why we need it at the moment)
The reason for this is if for example a malloc becomes 'bad' then all the frees that use it can be easily disregarded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65408/new/

https://reviews.llvm.org/D65408





More information about the llvm-commits mailing list