[PATCH] D66762: DAG: computeNumSignBits for MUL

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 16:09:45 PDT 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:3719
+  case ISD::MUL: {
+    const unsigned TyBits = Op.getValueSizeInBits();
+
----------------
RKSimon wrote:
> Can't we just use the VTBits variable? Also, getValueSizeInBits only works on scalar types.
Whoops, i thought i reviewed that bit, but looks like i looked at this line in next `case`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66762/new/

https://reviews.llvm.org/D66762





More information about the llvm-commits mailing list