[PATCH] D66741: [polly] Compute WAR dependence info using ISL kills

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 14:01:38 PDT 2019


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM. Please add "NFC" to the title for "No Functional Change" intended.

Please add a message if/when I can commit this for you.



================
Comment at: lib/Analysis/DependenceInfo.cpp:289-291
+buildFlow(__isl_keep isl_union_map *Snk, __isl_keep isl_union_map *Src,
+          __isl_keep isl_union_map *MaySrc, __isl_keep isl_schedule *Schedule,
+          __isl_keep isl_union_map *Kill = nullptr) {
----------------
[nit] It would be nice to keep the union_map's together and have schedule as the last argument.


Repository:
  rPLO Polly

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66741/new/

https://reviews.llvm.org/D66741





More information about the llvm-commits mailing list