[PATCH] D66755: [DAGCombiner] cancel fnegs from multiplied operands of FMA

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 13:27:26 PDT 2019


cameron.mcinally accepted this revision.
cameron.mcinally added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wuzish.

LGTM.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12282
   }
 
+  if (isCheaperToUseNegatedFPOps(N0, N1)) {
----------------
Maybe a comment here? Not critical though...

Something like: -X * -Y + Z --> X * Y + Z


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66755/new/

https://reviews.llvm.org/D66755





More information about the llvm-commits mailing list