[PATCH] D66663: [DebugInfo] LiveDebugValues should always revisit backedges if it skips them

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 12:16:35 PDT 2019


aprantl added a comment.

> I think (80%) there will still be some special casing needed though.

Unless we change the implementation of VarLocSet to actually include three values instead of two, I think you are right. We could try and see if something like:

1. not in the set -> ⊥
2. in the set -> true
3. in the set with a special KILL marker (perhaps implemented as an extra set of killed VarLocs) -> false

makes the implementation look more regular. This is not the only way to achieve this, just the first thing I came with on the spot.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66663/new/

https://reviews.llvm.org/D66663





More information about the llvm-commits mailing list