[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

Gábor Horváth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 10:02:26 PDT 2019


xazax.hun marked an inline comment as done.
xazax.hun added inline comments.


================
Comment at: clang/lib/Sema/SemaInit.cpp:6651
       visitLocalsRetainedByReferenceBinding(Path, Arg, RK_ReferenceBinding,
-                                            Visit);
+                                            Visit, true);
     else
----------------
mgehre wrote:
> Could we have argument comments here `/*EnableLifetimeWarnings=*/true,
> and especially below where multiple bool literals are passed?
Done in r369928.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66686/new/

https://reviews.llvm.org/D66686





More information about the llvm-commits mailing list