[PATCH] D66746: [LiveDebugValues] Omit entry values for DBG_VALUEs with pre-existing expressions

[David Stenberg via Phabricator via llvm-commits]

dstenb created this revision.
dstenb added reviewers: djtodoro, NikolaPrica, aprantl, vsk.
dstenb added a project: debug-info.
Herald added subscribers: llvm-commits, atanasyan, jrtc27, hiraditya, sdardis.
Herald added a project: LLVM.

Entry values are currently only supported for register DBG_VALUEs
with empty debug expressions, as the DW_OP_entry_value operation can
only wrap one byte. Creating an entry value for a DBG_VALUE with a
non-empty debug expression would result in an invalid expression.
This occurred for the parameter in the attached test case,
triggering an assert later on.


Repository:
  rL LLVM

https://reviews.llvm.org/D66746

Files:
  llvm/lib/CodeGen/LiveDebugValues.cpp
  llvm/test/DebugInfo/Mips/entry-value-non-empty-expr.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66746.217156.patch
Type: text/x-patch
Size: 5091 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190826/cf21f19e/attachment.bin>