[PATCH] D66279: [ELF] Make LinkerScript::assignAddresses iterative

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 02:48:04 PDT 2019


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/LinkerScript.cpp:1052
 
+static DenseMap<const Defined *, std::pair<SectionBase *, uint64_t>>
+getSymbolAssignmentValues(std::vector<BaseCommand *> sectionCommands) {
----------------
This needs a function comment.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66279/new/

https://reviews.llvm.org/D66279





More information about the llvm-commits mailing list