[PATCH] D66717: [ELF] Do not ICF two sections with different output sections (by SECTIONS commands)

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

I like this new approach because it seems more modular than before.



================
Comment at: ELF/ICF.cpp:503
+
+  // Remove folded input section members from output sections.
+  for (BaseCommand *base : script->sectionCommands)
----------------
This comment is perhaps a bit too terse. Can you explain in the comment why we are doing this?


================
Comment at: ELF/Writer.cpp:155
 
-static void copySectionsIntoPartitions() {
+void elf::copySectionsIntoPartitions() {
   std::vector<InputSectionBase *> newSections;
----------------
Maybe this and `createSynethticSections` should be moved to a new file if they are no longer a part of the writer?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66717/new/

https://reviews.llvm.org/D66717