[PATCH] D66729: [WebAssembly] Fix SSA rebuilding in SjLj transformation

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 26 01:50:59 PDT 2019


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyLowerEmscriptenEHSjLj.cpp:640
+      SSA.Initialize(I.getType(), I.getName());
+      SSA.AddAvailableValue(&BB, &I);
       for (auto UI = I.use_begin(), UE = I.use_end(); UI != UE;) {
----------------
This is just hoisting, because we were doing the same thing unnecessarily repeatedly in the inner loop. Not related to the bugfix itself.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66729/new/

https://reviews.llvm.org/D66729





More information about the llvm-commits mailing list