[PATCH] D66669: [X86] Remove what little support we had for MPX

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 25 07:18:44 PDT 2019


RKSimon added a comment.

I think this needs adding to the draft 10.0 release notes as well.



================
Comment at: llvm/lib/Target/X86/X86.td:244
                                       "Support ptwrite instruction">;
-def FeatureMPX     : SubtargetFeature<"mpx", "HasMPX", "true",
-                                      "Support MPX instructions">;
+// FIXME: This feature is deprecated and should not be used for anything, but
+// removing it would break IR files that may contain it in a target-feature
----------------
Add a note saying this was deprecated at llvm10? We're not great at removing deprecations (AutoUpgrade.....) but we should keep track.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66669/new/

https://reviews.llvm.org/D66669





More information about the llvm-commits mailing list