[PATCH] D66232: [InstCombine] Try to reuse constant from select in leading comparison

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri updated this revision to Diff 216916.
lebedev.ri marked 6 inline comments as done.
lebedev.ri added a comment.

Thanks for taking a look!
Addressed review nits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66232/new/

https://reviews.llvm.org/D66232

Files:
  llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
  llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp
  llvm/test/Transforms/InstCombine/canonicalize-clamp-with-select-of-constant-threshold-pattern.ll
  llvm/test/Transforms/InstCombine/reuse-constant-from-select-in-icmp.ll
  llvm/test/Transforms/InstCombine/unrecognized_three-way-comparison.ll
  llvm/test/Transforms/InstCombine/xor-of-icmps-with-extra-uses.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66232.216916.patch
Type: text/x-patch
Size: 26877 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190823/c9e3bd9c/attachment.bin>