[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

[Artem Belevich via Phabricator via llvm-commits]

tra marked an inline comment as done.
tra added inline comments.


================
Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:8416
+    // in the CheckFunctionTemplateSpecialization() call below.
+    if (getLangOpts().CUDA & !isFunctionTemplateSpecialization)
+      maybeAddCUDAHostDeviceAttrs(NewFD, Previous);
----------------
tra wrote:
> RKSimon wrote:
> > @tra Sorry for touching such an old ticket - but cppcheck is warning that we are using a boolean result in a bitwise expression - I'm assuming this should be:
> > ```
> > if (getLangOpts().CUDA && !isFunctionTemplateSpecialization)
> > ```
> Good catch. I'll fix it.
Fixed in rL369777.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D25845/new/

https://reviews.llvm.org/D25845