[PATCH] D66617: [llvm-dlltool] Make sure to strip decorations from ExtName for renamed exports

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 08:58:18 PDT 2019


mstorsjo added a comment.

In D66617#1642886 <https://reviews.llvm.org/D66617#1642886>, @jacek wrote:

> It looks like decoration is killed too aggressively now. If aliasee symbol has no decoration, aliased symbol is stripped.


Ah, crap. @hans - no point in backporting this, as it's a bigger mess than it seemed first.

@jacek - the issue stems from how these work in msvc land. You can have `/export:foo=bar` where the decoration from the actual bar symbol gets transplanted on foo, see https://github.com/llvm/llvm-project/blob/master/llvm/lib/Object/COFFImportFile.cpp#L604. In this case, the original symbol has no decoration to transplant on the stripped ExtName.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66617/new/

https://reviews.llvm.org/D66617





More information about the llvm-commits mailing list