[PATCH] D66612: [Reassoc] Small fix to support unary FNeg in NegateValue(...)

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL369772: [Reassoc] Small fix to support unary FNeg in NegateValue(...) (authored by mcinally, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D66612?vs=216680&id=216872#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66612/new/

https://reviews.llvm.org/D66612

Files:
  llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
  llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll


Index: llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll
===================================================================
--- llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll
+++ llvm/trunk/test/Transforms/Reassociate/2019-08-22-FNegAssert.ll
@@ -0,0 +1,24 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt < %s -reassociate -S | FileCheck %s
+; D61675
+
+define float @test1(float %arg, float %arg1, float %arg2, float %arg3) {
+; CHECK-LABEL: @test1(
+; CHECK-NEXT:    [[TMP5:%.*]] = fneg fast float [[ARG:%.*]]
+; CHECK-NEXT:    [[TMP1:%.*]] = fsub fast float [[ARG3:%.*]], [[ARG2:%.*]]
+; CHECK-NEXT:    [[TMP2_NEG:%.*]] = fadd fast float [[TMP5]], 5.000000e+02
+; CHECK-NEXT:    [[TMP3:%.*]] = fadd fast float [[TMP2_NEG]], [[TMP1]]
+; CHECK-NEXT:    [[TMP4:%.*]] = fmul fast float [[TMP3]], [[TMP3]]
+; CHECK-NEXT:    [[TMP6:%.*]] = fdiv fast float [[TMP5]], [[ARG1:%.*]]
+; CHECK-NEXT:    [[TMP7:%.*]] = fadd fast float [[TMP4]], [[TMP6]]
+; CHECK-NEXT:    ret float [[TMP7]]
+;
+  %tmp1 = fsub fast float %arg3, %arg2
+  %tmp2 = fadd fast float %arg, -5.000000e+02
+  %tmp3 = fsub fast float %tmp1, %tmp2
+  %tmp4 = fmul fast float %tmp3, %tmp3
+  %tmp5 = fneg fast float %arg
+  %tmp6 = fdiv fast float %tmp5, %arg1
+  %tmp7 = fadd fast float %tmp6, %tmp4
+  ret float %tmp7
+}
Index: llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
===================================================================
--- llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
+++ llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
@@ -861,7 +861,7 @@
     // this use.  We do this by moving it to the entry block (if it is a
     // non-instruction value) or right after the definition.  These negates will
     // be zapped by reassociate later, so we don't need much finesse here.
-    BinaryOperator *TheNeg = cast<BinaryOperator>(U);
+    Instruction *TheNeg = cast<Instruction>(U);
 
     // Verify that the negate is in this function, V might be a constant expr.
     if (TheNeg->getParent()->getParent() != BI->getParent()->getParent())


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66612.216872.patch
Type: text/x-patch
Size: 2102 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190823/4e76daf7/attachment.bin>