[PATCH] D66264: [ThinLTO] Fix handling of weak interposable symbols

Fri Aug 23 07:52:47 PDT 2019

tejohnson marked 3 inline comments as done.
tejohnson added a comment.

In D66264#1636359 <https://reviews.llvm.org/D66264#1636359>, @pcc wrote:

> LGTM
>
> This would also be fixed by switching to canonical aliases, right? Maybe another data point in favour of finally switching.

Yes, the alias issues would.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:911-912
 bool llvm::convertToDeclaration(GlobalValue &GV) {
+  //errs() << "Converting to a declaration:\n";
+  //GV.dump();
   LLVM_DEBUG(dbgs() << "Converting to a declaration: `" << GV.getName()
----------------
pcc wrote:
> Unintentional?
Yep, forgot to remove. Cleaned up here and below.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66264/new/

https://reviews.llvm.org/D66264