[PATCH] D65945: [LLVM][Alignment] Make functions using log of alignment explicit

[Clement Courbet via Phabricator via llvm-commits]

courbet added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2706
 
-  /// The size, in bytes, of the target's jmp_buf buffers
-  unsigned JumpBufSize;
----------------
Maybe split this change to a different commit ? Also, this is part of the public API. There might be external code that depends on this. Not sure what the policy here is. Did you reach out to the original author for this ?


================
Comment at: llvm/lib/CodeGen/MachineBlockPlacement.cpp:3105
     for (MachineBasicBlock &MBB : MF)
-      MBB.setAlignment(AlignAllBlock);
+      MBB.setLogAlignment(AlignAllBlock); // !!!
   else if (AlignAllNonFallThruBlocks) {
----------------
These are fine, maybe just update the doc of the flags ?


================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:184
   if (AlignAllFunctions)
-    Alignment = AlignAllFunctions;
+    LogAlignment = AlignAllFunctions; /// !!!
 
----------------
ditto.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65945/new/

https://reviews.llvm.org/D65945