[PATCH] D66505: Make add_new_check.py's insertion of registerCheck<> more closely match the sort order

Alexander Kornienko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 23 03:14:50 PDT 2019


alexfh added a comment.

In D66505#1641776 <https://reviews.llvm.org/D66505#1641776>, @aaron.ballman wrote:

> Given that the alphabetization we want really is based on the string literal, would it make sense to look for that rather than the check name? Adding a few more reviewers for a better mix of opinions.


Ideally, it would be nice to sort the list of registrations by the check name. But given that the call can span two lines, that may be slightly trickier to implement. It's worth giving it a try though ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66505/new/

https://reviews.llvm.org/D66505





More information about the llvm-commits mailing list