[PATCH] D66374: [SampleFDO] Add symbol whitelist in the profile and use it when profile-sample-accurate is enabled

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: include/llvm/ProfileData/SampleProf.h:116
+  SecNameTable = 1,
+  SecFuncProfile = 2,
+  SecSymbolWhiteList = 3
----------------
Name it 'SectEdgeProfile' or 'SecLBRProfile'?

Also move this after the WhiteList  and reserve some enum range between WhiteList and the firstProfile

enum SecType {
    SecProfileSummary = 0,
    SecNameTable = 1,
    SecWhiteList = 2,
    SecFuncProfileFirst = 0x10,   // marker for the first type of profile.
    SecLBRProfile = SecFuncProfileFirst
}

We should shoot for one profile type per section, but the hybrid mode you mentioned can also be supported if it is a size win.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66374/new/

https://reviews.llvm.org/D66374