[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

[Greg Clayton via Phabricator via llvm-commits]

clayborg marked an inline comment as done.
clayborg added inline comments.


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:98-101
+  if (!decodeAll(*this, Data, Offset, BaseAddr)) {
+    // If parsing failed, clear the object
+    clear();
+  }
----------------
We could leave it out as it was before. The decodeAll just returning a bool was for the recursion. It would actually be nice to have this fail with the data it was able to decode. Not sure what error we can really return besides "not enough data"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600