[PATCH] D66620: [sanitizer] Update symbolizer/scripts

[Igor Sugak via Phabricator via llvm-commits]

sugak created this revision.
sugak added reviewers: vitalybuka, bkramer.
Herald added projects: LLVM, Sanitizers.
Herald added subscribers: Sanitizers, llvm-commits.

Running `build_symbolizer.sh` on the latest master exits with error reporting missing symbol: `_ZN4llvm5MachO13TextAPIReader3getENS_15MemoryBufferRefE`. 
Updated `build_symbolizer.sh` to use `libLLVMTextAPI.a` that provides the missing symbol.

With the above, missing `isspace` is reported, add it to the `global_symbols.txt`


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D66620

Files:
  lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
  lib/sanitizer_common/symbolizer/scripts/global_symbols.txt


Index: lib/sanitizer_common/symbolizer/scripts/global_symbols.txt
===================================================================
--- lib/sanitizer_common/symbolizer/scripts/global_symbols.txt
+++ lib/sanitizer_common/symbolizer/scripts/global_symbols.txt
@@ -78,6 +78,7 @@
 isalpha U
 isatty U
 islower U
+isspace U
 isprint U
 isupper U
 isxdigit U
Index: lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
===================================================================
--- lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
+++ lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh
@@ -127,7 +127,7 @@
   $LLVM_SRC
 fi
 cd ${LLVM_BUILD}
-ninja LLVMSymbolize LLVMObject LLVMBinaryFormat LLVMDebugInfoDWARF LLVMSupport LLVMDebugInfoPDB LLVMMC LLVMDemangle
+ninja LLVMSymbolize LLVMObject LLVMBinaryFormat LLVMDebugInfoDWARF LLVMSupport LLVMDebugInfoPDB LLVMMC LLVMDemangle LLVMTextAPI
 
 cd ${BUILD_DIR}
 rm -rf ${SYMBOLIZER_BUILD}
@@ -152,6 +152,7 @@
                         $LLVM_BUILD/lib/libLLVMDebugInfoPDB.a \
                         $LLVM_BUILD/lib/libLLVMDemangle.a \
                         $LLVM_BUILD/lib/libLLVMMC.a \
+                        $LLVM_BUILD/lib/libLLVMTextAPI.a \
                         $ZLIB_BUILD/libz.a \
                         symbolizer.a \
                         all.bc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D66620.216715.patch
Type: text/x-patch
Size: 1345 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190822/2be76c43/attachment.bin>