[PATCH] D66498: [GlobalISel] Import patterns containing INSERT_SUBREG

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 14:02:00 PDT 2019


aemerson added inline comments.


================
Comment at: llvm/utils/TableGen/GlobalISelEmitter.cpp:4149
+  auto RC =
+      Target.getSuperRegForSubReg(Ty.getValueTypeByHwMode(), CGRegs, SubIdx);
+  return *RC;
----------------
`getSuperRegForSubReg()` seems to return an Optional, but here you get the value without checking if it's None.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66498/new/

https://reviews.llvm.org/D66498





More information about the llvm-commits mailing list