[PATCH] D66433: LibFuzzer support for 32bit MSVC

Thu Aug 22 13:52:11 PDT 2019

mstorsjo added a comment.

In D66433#1641769 <https://reviews.llvm.org/D66433#1641769>, @mcgov wrote:

> Committed revision 369704.
>  Committed 52c97db24d9 to svn.
>
> https://github.com/llvm/llvm-project/commit/2eaeba6f15d361687795dc429b78090ab38ff1d2

Please remember to link to the review in the commit message. Now it's easy to locate the commit from this review thread, but going the other way is more work.

================
Comment at: lib/fuzzer/FuzzerBuiltinsMsvc.h:41
+
+#if !defined(_M_ARM) && !defined(_M_X64)
+  // Scan the high 32 bits.
----------------
Wouldn't it be appropriate to check for `_M_ARM64` as well? Or just flip it around and make `#ifdef _M_IX86` the one singled out? (I guess we can't assume that any architecture except i386 will have 64 bit versions of these functions though so maybe it's appropriate to list the ones we do know support it...)

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66433/new/

https://reviews.llvm.org/D66433