[PATCH] D66612: [Reassoc] Small fix to support unary FNeg in NegateValue(...)

Cameron McInally via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 13:29:42 PDT 2019


cameron.mcinally added a comment.

In D66612#1641702 <https://reviews.llvm.org/D66612#1641702>, @mcberg2017 wrote:

> BTW, general comment: Many of the remaining BinaryOperator contexts in Reassociate.cpp will need re-examaination too as UnaryOperator may also be present in places where it currently is not.


Agreed.

If you have any test cases that I can use as an intuition pump, that would be great. I haven't worked that much in Reassociate.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66612/new/

https://reviews.llvm.org/D66612





More information about the llvm-commits mailing list