[PATCH] D63676: Early exit from Hoist() in machine licm pass based on block hotness

Victor Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 12:13:48 PDT 2019


NeHuang marked 4 inline comments as done.
NeHuang added a comment.
NeHuang added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:53
 #include <vector>
+#include "llvm/CodeGen/MachineBlockFrequencyInfo.h"
 
----------------
Whitney wrote:
> Please run clang-format on your change. The include is not added at the right place.
Done.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:1585
+  if (Ratio > BlockFrequencyRatioThreshold) {
+    NumNotHoistedDueToHotness++;
+    return true;
----------------
Whitney wrote:
> Change to `++ NumNotHoistedDueToHotness`
Done


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63676/new/

https://reviews.llvm.org/D63676





More information about the llvm-commits mailing list