[PATCH] D66605: Debug Info: Support for DW_AT_export_symbols for anonymous structs

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/CodeGen/AsmPrinter/DwarfUnit.cpp:950
+    if (CTy->getExportSymbols())
+      addFlag(Buffer, dwarf::DW_AT_export_symbols);
+
----------------
Please be sure to add more context the diffs in the future (`git diff -U9999`).


================
Comment at: test/DebugInfo/Generic/export-symbol-anonymous-class.ll:11
+; CHECK: DW_TAG_structure_type
+; CHECK-NEXT: DW_AT_calling_convention	(DW_CC_pass_by_value)
+; CHECK-NEXT: DW_AT_name	("A")
----------------
Why check for the calling convention in a test called export-symbol-anonymous-class.ll ?


================
Comment at: test/DebugInfo/Generic/export-symbol-anonymous-class.ll:14
+;
+; CHECK: DW_TAG_structure_type
+; CHECK-NEXT: DW_AT_export_symbols	(true)
----------------
Can you check that this is the inner nested struct by using a combination of CHECK-NEXT and CHECK-NOT: NULL?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66605/new/

https://reviews.llvm.org/D66605