[PATCH] D66600: Add encode and decode methods to InlineInfo and document encoding format to the GSYM file format

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:63
+
+static bool decodeAll(InlineInfo &Inline, DataExtractor &Data,
+                      uint64_t &Offset, uint64_t BaseAddr) {
----------------
This returns a bool.. what does that mean?


================
Comment at: lib/DebugInfo/GSYM/InlineInfo.cpp:84
+  uint64_t Offset = 0;
+  decodeAll(*this, Data, Offset, BaseAddr);
+}
----------------
and here the return value is ignored?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66600/new/

https://reviews.llvm.org/D66600