[PATCH] D66575: [AlignmentFromAssumptions] getNewAlignmentDiff(): use getURemExpr()

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 22 09:41:10 PDT 2019


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.

The original code tried to do the modulo computation (as per comment and the looks of it) but the operands of `DiffUnitsSCEV = SE->getMinusSCEV(DiffAlign, DiffSCEV)` were swapped.
Swapping them should yield the same result as using URem but using URem is better so this is fine.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66575/new/

https://reviews.llvm.org/D66575





More information about the llvm-commits mailing list