[PATCH] D66548: [DAGCombiner] Remove explicit call to AddToWorklist in sqrt and reciprocal computations

[Jinsong Ji via Phabricator via llvm-commits]

jsji added inline comments.


================
Comment at: test/CodeGen/PowerPC/qpx-recipest.ll:205
-; CHECK-DAG: qvfmadds
-; CHECK-DAG: qvfcmpeq
 ; CHECK-DAG: qvfmadds
----------------
xbolva00 wrote:
> deadalnix wrote:
> > jsji wrote:
> > > lebedev.ri wrote:
> > > > deadalnix wrote:
> > > > > RKSimon wrote:
> > > > > > deadalnix wrote:
> > > > > > > RKSimon wrote:
> > > > > > > > Is the qvfcmpeq removed as well?
> > > > > > > Let me double check, it may be an error of mine.
> > > > > > How bad would it be to use the update script and regenerate all the CHECKs?
> > > > > As far as I know, this is not available for PowerPC, unless something changed recently.
> > > > Shouldn't be too complicated to add
> > > I just tried, it should work.
> > As it turns out, I'm incorrect, so I'll do this and update the diff accordingly before landing.
> ./update_llc_test_checks.py ../test/CodeGen/PowerPC/qpx-recipest.ll
> 
> ./llvm-lit /home/xbolva00/LLVM/llvm/test/CodeGen/PowerPC/qpx-recipest.ll
> -- Testing: 1 tests, single process --
> PASS: LLVM :: CodeGen/PowerPC/qpx-recipest.ll (1 of 1)
> Testing Time: 3.74s
>   Expected Passes    : 1
> 
Simon have commited it in https://reviews.llvm.org/rL369659


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D66548/new/

https://reviews.llvm.org/D66548